After the latest Reactist changes (i.e. on next), any Tooltip component that wraps a Tab component (as in: Tooltip outside Tab) does not work (it's not rendered).
Workaround
Placing the Tooltip inside the Tab component makes it work. This is the fix that I'm suggesting we do in todoist-web for the time being (see https://github.com/Doist/todoist-web/pull/11139).
Edit: I guess the problem is that there might be other tooltips that are not working and that we have not noticed (or tooltips that might be added in the future), so fixing this in Reactist (if possible) would be ideal.
Steps to reproduce the bug
Place a Tooltip component outside the Tab component; verify that the tooltip does not get rendered.
See sample story in https://github.com/Doist/reactist/pull/833 (feature branch cut from next).
I think the Tooltip should work even if it's placed outside the Tab component (it used to work before the latest Reactist changes). See sample story in https://github.com/Doist/reactist/pull/835 (feature branch cut from main).
@gnapse Assigning this to you as you're the one who's performing the Reactist upgrade/update. If you don't have time, I could try looking into this as my housekeeping task for next week 🤷♀️
🐛 Bug report
Discovered while investigating https://github.com/Doist/Issues/issues/14457
Current behavior
After the latest Reactist changes (i.e. on
next
), any Tooltip component that wraps a Tab component (as in: Tooltip outside Tab) does not work (it's not rendered).Workaround
Placing the Tooltip inside the Tab component makes it work. This is the fix that I'm suggesting we do in todoist-web for the time being (see https://github.com/Doist/todoist-web/pull/11139).
Edit: I guess the problem is that there might be other tooltips that are not working and that we have not noticed (or tooltips that might be added in the future), so fixing this in Reactist (if possible) would be ideal.
Steps to reproduce the bug
Place a
Tooltip
component outside theTab
component; verify that the tooltip does not get rendered. See sample story in https://github.com/Doist/reactist/pull/833 (feature branch cut fromnext
).https://github.com/user-attachments/assets/5a66a1d8-d9e5-4342-a9a5-f5660d897bc2
Expected behavior
I think the Tooltip should work even if it's placed outside the
Tab
component (it used to work before the latest Reactist changes). See sample story in https://github.com/Doist/reactist/pull/835 (feature branch cut frommain
).https://github.com/user-attachments/assets/a80c2729-0127-417d-8274-0d363029efd4
Possible solutions
I'd say ideally we would ensure that the
Tooltip
component works even if outside theTab
component.