search

Doist / renovate-config

Shareable Renovate config templates - https://docs.renovatebot.com/config-presets/
2 stars 1 forks source link

[Frontend] Stop renovate from bumping `engines` or couple to `.nvmrc` updates #20

Open henningmu opened 2 years ago

henningmu commented 2 years ago

I noticed a case where renovate would bump the engines.node field in package.json from 16.13 to 16.15, but not update the corresponding line in .nvmrc resulting in CI failures. Ideally, we would couple node updates to include both places. If that's not possible, we should disable node updates.

@rfgamaral do you happen to have a snippet for that, the docs have not to been super helpful, yet 😅

rfgamaral commented 2 years ago

I noticed a case where renovate would bump the engines.node field in package.json from 16.13 to 16.15, but not update the corresponding line in .nvmrc resulting in CI failures.

That's strange. The value in .nvmrc (i.e. v16) should allow any v16.x version to work. And that's the whole point actually, to not force us to update to every minor Node.js version all the time, it should just work. Are you sure this is the problem we are facing? Can you link me to one of those CI fails?

If that's not possible, we should disable node updates.

Either way, I would probably go with this anyway. I feel like updating Node to major versions should be something that we do manually, and in a coordinated fashion, so that everyone in the team is aware of this change, and can plan to update their Nodejs version locally.

proxi commented 2 years ago

That is something I also noticed and reported, e.g. here so I don't think it's Frontend-only. Apart from package.json and .nvmrc there are also Dockerfiles, workflow files using explicit version syntax, and more.