Doist / typist

The mighty Tiptap-based rich-text editor that powers Doist products.
https://typist.doist.dev
MIT License
473 stars 12 forks source link

Peer dependencies not installed automatically #634

Closed philipp985 closed 10 months ago

philipp985 commented 10 months ago

Hello , thanks for the great library. I have some problems get in running. Here is my setup:

Then I run

npm install --save @doist/typist

I implement the editor according to the docs. But after running webpack I get these errros.

According to the docs the peer depedencies should be installed automatically. What do I need to do to do that? Thanks for any advice

rfgamaral commented 10 months ago

Hi @philipp985, I think you are misreading the documentation. With legacy-peer-deps=true, peer dependencies are NOT installed automatically, and you have to install them manually with this command.

philipp985 commented 10 months ago

Ok, sorry I overlooked not. Anyhow do you plan to switch from peerDependencies to dependendies to make installation simpler for people that have reading problems like me 😉 ? Or what is the reason behind this approach? I am just curious.

rfgamaral commented 10 months ago

Anyhow do you plan to switch from peerDependencies to dependendies

We have no plans to do this.

Or what is the reason behind this approach?

Most of the Typist peer dependencies are directly used by our products, and between Todoist, Twist, and Typist, these dependencies follow different upgrade paths. This allows us to keep Typist dependencies up-to-date, without forcing an upgrade in our products dependencies. Sometimes those are not trivial to do, and we still need to keep new Typist versions coming into our products without any disruptions.