search

Doist / typist

The mighty Tiptap-based rich-text editor that powers Doist products.
https://typist.doist.dev
MIT License
471 stars 12 forks source link

chore(storybook): Prevent `keyDown` propagation with hidden suggestion dropdown #919

Closed rfgamaral closed 1 month ago

rfgamaral commented 1 month ago

Overview

Both the Mention and Hashtag suggestion dropdowns have an issue where any keyDown event is propagated to the dropdown renderer component after the dropdown has been hidden. This PR fixes that by detecting whether the dropdown is hidden or not, and disallowing the keyDown event propagation in case it's hidden.

[!NOTE] This does not affect the production Typist build, it only fixes the Storybook examples.

PR Checklist

netlify[bot] commented 1 month ago

Deploy Preview for doist-typist ready!

Name Link
Latest commit 983b7729b3f8d8d09fed702e2e71afb4a0da4e29
Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/66fa8dc029d3ae0008623cbe
Deploy Preview https://deploy-preview-919--doist-typist.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

doistbot commented 1 month ago

:tada: This PR is included in version 7.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: