Doko-Demo-Doa / react-native-shake

React Native shake event detector
MIT License
261 stars 64 forks source link

Does not work with new architecture on iPhone #56

Closed TaylorOno closed 10 months ago

TaylorOno commented 1 year ago

Steps to reproduce

npx react-native@latest init shake-feature
npm install react-native-shake
cd ios
RCT_NEW_ARCH_ENABLED=1 pod install
cd ..
npm run ios

output

** BUILD FAILED **

The following build commands failed:
        CompileC /Users/otaylor/Library/Developer/Xcode/DerivedData/shakefeature-dxixmjagieegoqcfiycawrtajqqq/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-shake.build/Objects-normal/x86_64/RNShake.o /Users/otaylor/workspace/shakefeature/node_modules/react-native-shake/ios/RNShake.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-shake' from project 'Pods')
image

NativeRNShake interface is not generated as part of code gen

This appears to related to compiling the NativeRNShake.ts file to javascript, code gen is no longer correctly detecting it.

TaylorOno commented 1 year ago

potential fix https://github.com/Doko-Demo-Doa/react-native-shake/pull/57