DoliCloud / SellYourSaas

Sell-Your-Saas is an Open Source solution to automate and sell any Web application as a SaaS service
https://www.sellyoursaas.org
GNU General Public License v3.0
226 stars 76 forks source link

FIX: with some versions of rsync, option --noatime fails #360

Closed atm-florianm closed 6 months ago

atm-florianm commented 6 months ago

SellYourSaas seems to be aware of the issue already, but the current detection method (using Ubuntu version) is less reliable than using rsync --help and see if the option is described in the help text.

However, I am not used to executing shell commands from PHP and not comfortable with using the captured stdout. I'm open to better methods (like detecting rsync capabilities only once at install time, in an actual shell script, and storing the detection result in sellyoursaas.conf or any convenient place).

hregis commented 6 months ago

@atm-florianm this is --noatime not --noasync ;-)

atm-florianm commented 6 months ago

Oopsie, brain malfunction... Thanks for pointing it out ;)

hregis commented 6 months ago

@atm-florianm I understand...my brain is failing too! ;-)