Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.46k stars 2.79k forks source link

10.0.6: list of projects via Project "Modify" for existing proposal #12999

Closed 2dig4it closed 3 years ago

2dig4it commented 4 years ago

Background

Dolibarr 10.0.6 / stable release | --> seems to be still the case in "devel" git release? (I did only a quick check)

Brief description

Example: I have a commercial proposal, project support is enabled. I can select one of the available projects. It is correctly saved for the proposal. BUG/ISSUE: when afterwards modifying via "MODIFY" in the list I can not select anything else, only the original project or nothing. Permissions are correct.

For me this is also in other modules an issue (i.e., I want to change an entry in the agenda).

In: dolibarr/htdocs/comm/propal/card.php/ :100:

This is the current situation

10.X: user can not select any other project, if no project is selected (i.e., accident) we can not change anything:

$morehtmlref.=$formproject->select_projects($object->socid, $object->fk_project, 'projectid', $maxlength, 0, 1, 0, 1, 0, 0, '', 1);

It should be: $formproject->select_projects( -1, ...

so that the list of projects is returned to select from

para 1: -1 --> list to select from and make changes / note: I did not check, what the other parameters should be

$morehtmlref.=$formproject->select_projects(-1, $object->fk_project, 'projectid', $maxlength, 0, 1, 0, 1, 0, 0, '', 1);

Issue is in source code: screenshot

What I don't understand

In online shared testing environment:

it is no issue ?!? --> in an existing proposal the associated project can be modified. Do they have their own version,

eldy commented 4 years ago

I can't reproduce bot with 10.0.6 and nay other version. Do you use external modules ? Did you enabled hidden options ? Can you test with v11 ?

2dig4it commented 4 years ago

This is a quick follow up. I'm working on it and it is not forgotten. Issue remains with new versions.

** STEPs done:

** NOT SO IMPORTANT PERSONAL BACKGROUND INFORMATION: I'm working a while now (1+ year) with Dolibarr from user perspective. Want to use it as new ERP in my company. Still in the process of careful transition to replace old (partially self programmed solutions). I'm planning to spend a bit of time and resources for the project. <<<

2dig4it commented 4 years ago

Do you use external modules? NO

Did you enabled hidden options ? YES, if hidden options are those under: https://wiki.dolibarr.org/index.php/Setup_Other

This is a list (please give a hint, if there is an easier way to create a dump) dolibarr_issue_projects_config_productiveuse

Can you test with v11 ? Yes. I can NOT reproduce with v11 and a clean install. I Can reproduce with v11 and migrated data from v10 (productive installation)

In case of testing with v11 in a clean install (in my environment which is a hosted webspace) I have the issue that I can not assign a project to a proposal (list is there, projects are disabled - visible but not selectable). So I can not reach the point, allowing further tests for this current issue, without editing in the database. Note: projects are public, and I'm logged in in Dolibarr as Sysadmin*.

dolibarr_issue_projects_not_chooseable

2dig4it commented 4 years ago

I disabled experimental features and set MAIN_FEATURES_LEVEL to 0 in the hidden options

Afterwards it works in 11.0 - the list of projects is shown and I can another project via Modify for an existing proposal.

So in dependence of issue treatment - this issue could also be closed (if behavior with MAIN_FEATURES_LEVEL=1) is not of relevance.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).