search

Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.45k stars 2.79k forks source link

Decimal comma in field "Quantity" is not properly registered #14666

Closed jacmart closed 3 years ago

jacmart commented 4 years ago

Bug

Decimal comma in field "Quantity" is not properly registered when user interface is localized to a "Latin spelling" (therefore not using the English "decimal point "spelling for fractions). On several input forms, it produces unexpected results.

Environment

Expected and actual behavior

The quantity field describing a product can be written with a comma (e.g. 0,5) in the "latin" (e.g. French, German etc...) localized interfaces. However in some cases while it is only the English decimal point that can be used, the input of a comma yields unexpected results

Steps to reproduce the behavior

Input of a comma for fraction of product quantity in the following forms 1. Nouvelle propale behavior: no warning, page reloading, no reaction

2. Expedition (> envoi partiel) behavior: the comma input triggers a warning : "le champ "Qté. a expedier/entrepot" est obligatoire". However that warning itself might be somewhat misleading

3. Corriger stock (< stock < produit ) Following a [conversation on the English Dolibarr forum with fappels , a fix has been already implemented for version 13

Workaround Until it is fixed, use the decimal point for describing fractions in quantities in all the described cases

No fix needed All the following forms and quantity fields behave nicely with fraction commata as expected in French localized interface

RELATED BUG

There is yet another specific inconsistency related both to the comma bug and stock movements : the stock movement list ends up displaying events that were not registered because of the comma bug. They are therefore misleading as they had no impact on the stock.

This related bug might or might not be cured partially by curing the actual comma problem. As far as I could test it, the decimal commata but also negative numbers deceivingly appear in the list of movements (they are not truly registered in the stock though).

atm-maxime commented 4 years ago

Thanks for this detailed issue !

atm-maxime commented 4 years ago

Hi. I just made a few test in v11. Seems to me that when adding a line in a proposal, using a qty like "1,5" is correctly working.

In shipments and in stock, you're right, it works with the ".", not with the ",".

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).