Problem with "Approver" filter on holiday list

Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.

https://www.dolibarr.org

GNU General Public License v3.0

5.39k stars 2.77k forks source link

Problem with "Approver" filter on holiday list #21311

Open leny0769 opened 2 years ago

leny0769 commented 2 years ago

Bug

For users who are not administrators, the drop-down list is filtered. But, it is reversed. A non-administrator user can filter on all users except himself, while it should be possible to filter only on himself. I think we have to change the variable $excludefilter in holiday/list.php, like this :

Before :
After :

Environment Version

v15

Environment OS

No response

Environment Web server

No response

Environment PHP

No response

Environment Database

No response

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

No response

alkaan commented 1 year ago

For all users we can present all approvers, this list won't depend on connected user, except for admin perhaps who can have all user in the list :

ksar-ksar commented 1 year ago

Hello,

Is it still the case on V18 ?

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).