Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.52k stars 2.81k forks source link

Translation inconsistent #23022

Closed John-H-Smith closed 1 month ago

John-H-Smith commented 2 years ago

Bug

Translations in the companies are inconsistent. I'm using de_DE as language. If navigating to /societe/card.php, you can (with module notifications enabled) see a tab 'Benachrichtigungen'. But while accessing societe/consumption.php or societe/paymentmodes.php, it uses the default fallback 'Notifications'. I followed the paths in the code to core/class/translate.class.php (line 612, function trans($key....). The associative array tab_translate in the translate.class.php is different for the three frontend pages (card.php, consumption.php and paymentmodes.php). For card.php, the key 'Notifications' is set. But the key isn't present in the both other cases. As I first would have to read into the docs and the translation mechanism, I assume it would be much quicker if you just check it yourself.

P.S.: In the langs/de_DE/companies.lang file is no 'Notifications' key set either.

Environment Version

16.0.2

Environment OS

AlmaLinux release 8.6

Environment Web server

Apache/2.4.37

Environment PHP

PHP 7.4.33

Environment Database

10.6.10-MariaDB

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

image

image

image

ksar-ksar commented 1 year ago

Hello,

It is still the case with V18 ?

John-H-Smith commented 1 year ago

Hi @ksar-ksar , yes it is (Dolibarr v18.0.0).

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).