Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.46k stars 2.79k forks source link

phpoffice/PhpSpreadsheet or phpoffice/phpexcel #23684

Closed Daviid-P closed 1 year ago

Daviid-P commented 1 year ago

Bug

Which one should we have in composer.json? Should we even have a composer.json file?

I see https://github.com/Dolibarr/dolibarr/blob/develop/composer.json.disabled (Which has phpoffice/phpexcel)

Right now I have this:

{
  "name": "dolibarr/dolibarr",
  "type": "project",
  "description": "Dolibarr ERP & CRM is a modern and easy to use web software to manage your business",
  "keywords": [
    "erp",
    "crm",
    "invoice",
    "sme",
    "proposal",
    "order",
    "stock",
    "agenda"
  ],
  "homepage": "https://www.dolibarr.org",
  "license": "GPL-3.0-or-later",
  "support": {
    "issues": "https://github.com/Dolibarr/dolibarr/issues",
    "forum": "https://www.dolibarr.org/forum",
    "wiki": "https://wiki.dolibarr.org",
    "source": "https://github.com/Dolibarr/dolibarr"
  },
  "config": {
    "vendor-dir": "htdocs/includes"
  },
  "require": {
    "php": "7.4.29",
    "ext-curl": "*",
    "ckeditor/ckeditor": "4.12.1",
    "mike42/escpos-php": "2.2",
    "mobiledetect/mobiledetectlib": "2.8.34",
    "phpoffice/phpexcel": "1.8.1",
    "restler/framework": "3.0.0-RC6",
    "tecnickcom/tcpdf": "6.3.2",
    "nnnick/chartjs": "2.9.3",
    "stripe/stripe-php": "6.43.1"
  },
  "require-dev": {
    "php-parallel-lint/php-parallel-lint": "0.9.2",
    "php-parallel-lint/php-console-highlighter": "0.4",
    "phpunit/phpunit": "4.8.36",
    "squizlabs/php_codesniffer": "3.7.1",
    "phpunit/phpunit-selenium": "2.0.3"
  },
  "suggest": {
    "ext-mysqlnd": "To use with MySQL or MariaDB",
    "ext-mysqli": "To use with MySQL or MariaDB",
    "ext-pgsql": "To use with PostgreSQL",
    "ext-mssql": "To use with MSSQL (experimental)",
    "ext-pdo_sqlite": "To use with SQLite (experimental)",
    "ext-gd": "Image manipulation (Required but maybe built-in PHP)",
    "ext-imagick": "Generation of thumbs from PDF",
    "ext-mcrypt": "(Required but maybe built-in PHP)",
    "ext-openssl": "Secure connections (Emails, SOAP…)",
    "ext-mbstring": "Handle non UTF-8 characters",
    "ext-soap": "Native SOAP",
    "ext-zip": "ODT, Excel and file compression support",
    "ext-xml": "Excel support"
  }
}

I set up the versions to whatever I had when Dolibarr was working correctly so, if I had to add anything for myself, I wouldn't mess up whatever package came by default. (Also I'm pretty sure this json is from v13.0.1, it had jakub-onderka/php-parallel-lint instead of php-parallel-lint/php-parallel-lint)

Environment Version

16.0.3

Daviid-P commented 1 year ago

PSA: Do not delete ./htdocs/includes in 16.0.3, composer install will not install all necessary libraries. I just tried and messed up because ADODB was missing :P