Preffered shipping method (SOCIETE_ASK_FOR_SHIPPING_METHOD) broken by #24716

[jobrien2001]

Bug

24716

$form->selectShippingMethod(((GETPOSTISSET('shipping_method_id')` && GETPOST('shipping_method_id', 'int') != 0) ? GETPOST('shipping_method_id') : $shipping_method_id), 'shipping_method_id', '', 1, '', 0, 'maxwidth200 widthcentpercentminusx');

Should be > 0 not != 0 ??

I dont know php but this seems to fix it.

Looks like other fields may be affected by the same change?

Environment Version

17.02

Environment OS

win10

Environment Web server

WAMP

Environment PHP

7.4

Environment Database

mariadb

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

-Set default shipping on third party -Create order, shipping is not selected

Attached files

No response

[bos4711]

Where do you set default shipping on third party?

[jobrien2001]

Where do you set default shipping on third party?

"Other setup", set SOCIETE_ASK_FOR_SHIPPING_METHOD to 1

You can find most vars in the docs.

[bos4711]

Works fine for me (v17.0.2 / PHP 7.0).

[jobrien2001]

Thats odd, it doesnt work for me. Im on php 7.4. Are you using the sourceforge 17.02 release?

[bos4711]

Yes, we use the SF-release.

[bos4711]

Just tested this with PHP 8.0 / Doli 17.0.2 and it works fine there as well.

[github-actions[bot]]

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).