Able to generate direct debit (withdraw) demand several time for same invoice

[vmaury]

Bug

I experienced the following bug

• in customer invoice list, select one invoice for direct debit = withdraw request
• generate xml direct debit file for one invoice
• if the xml is generated and the invoice is unpaid, it's possible to re-select the same invoice for withdraw request another time without errors.

I supposed it's possible in case the withdraw is rejected, but in most cases it seems dangerous to me (in my case, the client has been debited twice :-1: )

To solve this, I made this modif in code /htdocs/compta/facture/list.php around line #516-252 delete some conditions

$rsql = "SELECT pfd.rowid, pfd.traite, pfd.date_demande as date_demande";
                $rsql .= " , pfd.date_traite as date_traite";
                $rsql .= " , pfd.amount";
                $rsql .= " , u.rowid as user_id, u.lastname, u.firstname, u.login";
                $rsql .= " FROM ".MAIN_DB_PREFIX."prelevement_demande as pfd";
                $rsql .= " , ".MAIN_DB_PREFIX."user as u";
                $rsql .= " WHERE fk_facture = ".((int) $objecttmp->id);
                // $rsql .= " AND pfd.fk_user_demande = u.rowid"; // fix this bug 
                // $rsql .= " AND pfd.traite = 0"; // fix this bug 
                $rsql .= " ORDER BY pfd.date_demande DESC";

I'll make a PR if @eldy @aspangaro have no better suggestions ...

Environment Version

all (including develop branch)

Environment OS

No response

Environment Web server

No response

Environment PHP

No response

Environment Database

No response

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

No response

[eldy]

I don't think the fix is a good idea. We can make several times the request to make the direct debit because user may want/need to make the payment in several times. The problem is on the page compta/facture/prelevement.php When you go a second time on the document, you should be able to make a second request. BUT, the bug is that the amount suggested (here the 10.45) must be the amount to pay minus the amount already in the pipe. In this example it should be 10.45 - 5 = 5.45 Can you suggest a fix this way ?