Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.46k stars 2.79k forks source link

Menu management #28979

Open zephyriony opened 7 months ago

zephyriony commented 7 months ago

Bug

Today I'm reporting a major bug that's been around for a while (probably since the early days of Dolibarr). We really need to rethink the way the menus are managed. Passing menus to get doesn't seem ideal to me. We've noticed this bug in v14, v16 and v19, which can destabilize and annoy native users:

screenDolibarr

In the example below, by navigating between the tabs, you end up with the project menu in the product module. I can't say exactly how this happens, but I think it has something to do with the get variables thing, and given how often this happens, I think many Dolibarr users have to deal with this annoying problem.

Dolibarr Version

19.0

Environment PHP

7.4

Environment Database

mysql

Steps to reproduce the behavior and expected behavior

Among other things, the bug occurs when you click on a project and then use the browser arrow to go back to the product page.

Attached files

No response

hregis commented 7 months ago

@zephyriony and what is the exact process to get there?

hregis commented 7 months ago

@zephyriony Where are you at the base, and what do you click on, etc.?

zephyriony commented 7 months ago

Where are you at the base, and what do you click on, etc.?

1 - Login 2 - Go to product 3 - Go to project 4 - Return to product using browser arrow (tested on Chrome)

Even though it's never a good idea to use this arrow, native users use it all the time, so I think that's where the problem lies, with the get variables. There's no doubt a reason for managing menus with get, but I'd rather have seen it in the sql database.

zephyriony commented 3 months ago

I'm relaunching because it's really annoying and I've proposed a new feature #30427