Impossible to modifiy "Domiciliation du compte" in "Banques"

Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.

https://www.dolibarr.org

GNU General Public License v3.0

5.45k stars 2.79k forks source link

Impossible to modifiy "Domiciliation du compte" in "Banques" #30980

Closed apio-sys closed 1 month ago

apio-sys commented 1 month ago

Bug

Impossible to modifiy "Domiciliation du compte" in "Banques". After changing it, it is visible under the title of the banque but when going back to the list the modification is lost.

Dolibarr Version

19.0.3

Environment PHP

8.2.20

Environment Database

10.11.6-MariaDB-0+deb12u1 Debian 12

Steps to reproduce the behavior and expected behavior

Go into Bank, select an account and click modify.
Change something in the field "Domiciliation du compte" / "BankAccountDomiciliation".
Save the change with the "Modify" button.
The change reflects on the main account screen, below the account name.
Navigate away (for instance using "return to list").
The change is lost.

Expected behaviour: changes should be saved of course.

Attached files

No response

apio-sys commented 1 month ago

In class/account.class.php I notice the following comment public $domiciliation; // deprecated, use now address However, there is no field address in the [prefix]_bank_account table. There is mention of this in the ChangeLog

***** ChangeLog for 20.0.0 compared to 19.0 *****
QUAL: Deprecated "domiciliation". Replaced with "address"

but I'm still on 19.0.3. I think this should be rolled-back in current production version.

apio-sys commented 1 month ago

Thanks for your fix. Just tested it and functionality has been restored as before. However, I can't see the rationale of such code changes. If the idea was just to get rid of the French word, well then address is a bad translation for domiciliation which actually also is an English term and is logic in this case of the bank (https://dictionary.cambridge.org/dictionary/english/domiciliation). This can cause confusion since we already have an address for the owner. And in the end we have lots of double references to address and domiciliation making the code and dB less understandable. IMHO it would be best to revert how it was which was just fine. WDYT @eldy ?