search

Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.46k stars 2.79k forks source link

Missing variable ¨default_vat_code¨ in the product import script #31082

Open PepeBarz opened 1 month ago

PepeBarz commented 1 month ago

Bug

Correctly importing an inventory requires filling variable default_vat_code or the commercial module will not pick up the correct tax rate in things like proposals. The product import routine seems to be lacking the field to import the default_vat_code variable thus requiring that you either go product by product resetting the tax code or else go fix it in the table with SQL

Dolibarr Version

19 and 20

Environment PHP

8.2.18

Environment Database

MySQL DB 5.7.23-23

Steps to reproduce the behavior and expected behavior

-Create a list of possible tax codes, this is mine for Costa Rica image -Create a sample CSV import file in UTF-8 -Fill the columns (you will find that there is not a field for the variable default_vat_code) -Import the product inventory -The program will recognize the tax value for the product list but since there is no import field for default_vat_code the variable is not properly filled image -Thus, it will not recognize the associated tax code image -You have to manually correct by modifying the default product sell price image -If this is not properly set the proposal module will not process correctly the product data, it will not capture the sales tax field, since I have already corrected product BR-BIM, I will display in the image the next product BR-BIM-NET which has not been corrected, as you can see, the tax is not correctly picked up, the field is blank image Finally, it seems that the fields to enter price are a bit small as you create the sale line and further it seems like selecting a product in a currency proposal should populate the currency converted value on the fly but I guess that is for a feature request

Attached files

No response

mikko80 commented 3 weeks ago

I just ran into the same problem. It seems that the tax is not displayed correctly or it is reset to NULL in the llxe2_product table if the product does not have a row in the llx_product_price table Temporary workaround: make global VAT chance twice, to some dummy VAT and then back to correct VAT. This generate rows to llx_product_price. Then set correct VAT all rows in DB to llx_product_price.