Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.47k stars 2.8k forks source link

Possibility to not generate documents for recurrent supplier invoices #31810

Open mdeweerd opened 1 day ago

mdeweerd commented 1 day ago

Feature Request

I do not need the generated recurrent supplier invoice document (PDF) which is just noise - I add the actual supplier invoice to the database.

It's not possible to "unselect" the invoice model nor disable the invoice document (PDF) generation:

{0B170B48-17D4-4651-9A46-9805C216A7D0}

Use case

Avoid useless document generation, exports, misinterpretation (seemingly attached invoice, but actually internally generated "supplier invoice").

I generate recurrent invoices for monthly supplier services.

Suggested implementation

Allow to select the "empty line" for the document model. IMHO, no document model should be selected by default.

Suggested steps

No response

hregis commented 1 day ago

@mdeweerd @eldy I thought there was a constant to enable or disable the generation of the pdf for supplier invoices? Because I don't see the point of such a pdf because it is the original invoice from the supplier that is authentic. Maybe add such a constant to disable the generation of the pdf for supplier invoices as a whole?

sonikf commented 1 day ago

Ηι @mdeweerd

Option already exists

rec

mdeweerd commented 1 day ago

@sonikf Thank you for the reference, however IMHO that option (I have 2 options because I have two models) is to make invoice models available. I'll check if disabling them is a workaround, but I can not set an empty model in the recurrent invoice template.

I imagine that there are cases where one is creating official invoices on behalf of a third party (partner), but not for all third parties of course as most will be regular suppliers.

EDIT: Disabling the templates at least enables to unset them in the invoice generation models.

sonikf commented 1 day ago

I imagine that there are cases where one is creating official invoices on behalf of a third party (partner), but not for all third parties of course as most will be regular suppliers.

In this case it is considered a customer invoice not a supplier invoice and the customer invoice templates should be used but i don't think is implemented..

Anyway with the upcoming e-invoice this feature will soon be moot as all supplier invoices will be transmitted to and auto received by the system.

eldy commented 1 day ago

@sonikf Thank you for the reference, however IMHO that option (I have 2 options because I have two models) is to make invoice models available. I'll check if disabling them is a workaround, but I can not set an empty model in the recurrent invoice template.

I imagine that there are cases where one is creating official invoices on behalf of a third party (partner), but not for all third parties of course as most will be regular suppliers.

EDIT: Disabling the templates at least enables to unset them in the invoice generation models.

The template that should be used during generation of doc is the one setvas "default". The switch green on/off is to say "template in the combo list or not". So to have no generation, just uncheck the default value. This works for supplier invoice, but may be this is not correctly implemented for "recurrent" templates. If not, this is a bug, it should. By default, there is no default on invoice templates so no document is generated because we prefer to use the document provided by the supplier.

mdeweerd commented 1 day ago

@eldy I my setup none of the invoice templates was set as the default, but two templates were enabled. In the configuraiotn of the recurrent invoice, I could not unset the template name. After disabling the templates, the invoice was still configured with the same template as before, but I could modify it to be empty.

So it seems there are 2 issues:

  1. The recurrent invoice should not have a template selected by default.
  2. It should be possible to unset the template used by the recurrent invoice even if there is a default.

Also, IMHO, the default template should only be the default for the effective invoice detail when generating the invoice PDF using the generate button, and possibly the default proposed when the user wants to set the template for the recurrent invoice configuraiotn.

eldy commented 1 day ago

@eldy I my setup none of the invoice templates was set as the default, but two templates were enabled. In the configuraiotn of the recurrent invoice, I could not unset the template name. After disabling the templates, the invoice was still configured with the same template as before, but I could modify it to be empty.

So it seems there are 2 issues:

  1. The recurrent invoice should not have a template selected by default.
  2. It should be possible to unset the template used by the recurrent invoice even if there is a default.

Also, IMHO, the default template should only be the default for the effective invoice detail when generating the invoice PDF using the generate button, and possibly the default proposed when the user wants to set the template for the recurrent invoice configuraiotn.

I agree with the 2 issues.