Dolibarr / dolibarr

Dolibarr ERP CRM is a modern software package to manage your company or foundation's activity (contacts, suppliers, invoices, orders, stocks, agenda, accounting, ...). it's an open source Web application (written in PHP) designed for businesses of any sizes, foundations and freelancers.
https://www.dolibarr.org
GNU General Public License v3.0
5.51k stars 2.8k forks source link

fix: CronJob Property 'comment' do not exist replace by note_private #31970

Closed FHenry closed 1 week ago

FHenry commented 1 week ago

image

Should we change module template boilerplate and all core module cronjobs creation on activation to change array key name from "comment" to "note_private" to keep consistancy between declaration and field name ? like in https://github.com/Dolibarr/dolibarr/blob/b2bad15a046d13594efd463fcf10fe899e2eb736/htdocs/core/modules/modAgenda.class.php#L125 or https://github.com/Dolibarr/dolibarr/blob/b2bad15a046d13594efd463fcf10fe899e2eb736/htdocs/modulebuilder/template/core/modules/modMyModule.class.php#L276