search

DolphFlynn / jwt-editor

A Burp Suite extension for creating and editing JSON Web Tokens. This tool supports signing and verification of JWS, encryption and decryption of JWE and automation of several well-known attacks against applications that consume JWT.
Apache License 2.0
12 stars 11 forks source link

Added pull handles to JWT editor view #17

Closed eldstal closed 10 months ago

eldstal commented 10 months ago

In the current version, the JWT editor is inflexible and hard to read on small screens or with larger font sizes.

This PR adds two pull handles to the JWT editor tab (as shown in Burp request/response views). The user can use these to vertically shrink the serialized text field and the signature hex view, to focus on the contents of the token.

Current cramped view: image

More helpful view (note the pull handles between serial, tabview and signature): image

DolphFlynn commented 10 months ago

Thanks for the PR. It looks like a really nice improvement!

Do you think that the JWE panel should have them as well?

eldstal commented 10 months ago

The top divider applies whichever tab is selected (the SplitPanel which provides it is a parent of the Tab panel).

I saw no obvious place to put a divider inside the JWE tab, it seems more balanced (multiple similar fields) than the JWT panel (more commonly useful stuff followed by the large Signature field).

I may have missed something, but placing two dividers in the JWE tab would (AFAICT) lead to a hierarchy of paired panels, which probably wouldn't behave as the user would expect.

DolphFlynn commented 10 months ago

Fair enough :+1:

I'll merge it now and email PortSwigger over the weekend to kick start getting it into the BAppStore.