search

Dolphiq / craft3-iconpicker

Craft plugin that provides a new field type that offers end users an easy way to pick an icon from a .woff or .ttf font file. You can easily use ionicons or font awesome icons or any other compatible font file.
MIT License
16 stars 11 forks source link

Store fonts in storage rather than in the vendors folder and allow fonts path to be set in a config file. #8

Open Gnative opened 6 years ago

Gnative commented 6 years ago

Storing the fonts within the vendors directory doesn't seem right to me, this should be a folder that we shouldn't touch.

We should also be able to set the fonts folder with in a config file so as to be able to suit our projects structure.

24hoursmedia-craftcms commented 6 years ago

yes please, I tried to deploy on production using git pull and composer install etc, but there is no sound way to get the fonts into the vendor directory. One should not write in the vendor directory anyways.

bertoost commented 6 years ago

By default it should be in the storage/ folder somewhere and configurable if you already have FA included for the frontend website (or something like that)

devotoare commented 5 years ago

This. Having this not be the default (which it should be) or even configurable at the very least stops me from using this package completely. Too much messing around with gitignores and stuff to make this work across environments.

mateostabio commented 5 years ago

Any solutions on this? Does anyone have instructions on how to put my TTF files in my /web/assets/ folder? My live server is not displaying the icons and bugging out my admin.

cosly commented 5 years ago

+1

EternalBlack commented 4 years ago

Seems like this is the corresponding line of code causing us all trouble.

I'll fork the repo and try to fix this issue and'll open a pull-request afterwards.

kisonay commented 4 years ago

Any update on this?

devotoare commented 4 years ago

Any update on this?

Nope this project seems abandoned. We moved on years ago.