search

Dolphiq / craft3-plugin-sitemap

A craft 3 plugin that provides an easy way to enable and manage an XML sitemap for search engines like Google
MIT License
28 stars 18 forks source link

Composer 2 compatibility fix #57

Closed martijn-dolphiq closed 3 years ago

martijn-dolphiq commented 3 years ago

Changed the uppercase "S" to a lowercase "s" to fix a Composer 2 compatibility issue.

remmelt commented 3 years ago

Ah, right. My PR does the same. Can we get this merged somehow?

gbowne-quickbase commented 3 years ago

This has been sitting out for a long time and it's a single character of code that will stop composer from complaining on every install. Please merge it.

dolphiq-allard commented 3 years ago

šŸ‘šŸ¼

On Fri, 9 Apr 2021 at 12:55, Johan Zandstra @.***> wrote:

Merged #57 https://github.com/Dolphiq/craft3-plugin-sitemap/pull/57 into master.

ā€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Dolphiq/craft3-plugin-sitemap/pull/57#event-4573793006, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA4YCOYNSHIU52YULS2GCDTH3MJTANCNFSM4TA2JYOA .

--

Met vriendelijke groet Allard Rothengatter

CEO Dolphiq BV

Dolphiq.nl https://dolphiq.nl +31 (0)35 20 300 52 Rembrandtlaan 1b, 3723 BG Bilthoven <+31352030052> Op alle door Dolphiq te leveren producten en werkzaamheden zijn de algemene voorwaarden (mei 2018) van Dolphiq BV, gedeponeerd bij de Kamer van Koophandel te Utrecht onder nummer 5ā€Œ50ā€Œ976ā€Œ69, van toepassing. U kunt onze algemene voorwaarden ook hier downloaden https://dolphiq.nl/media/Algemene-Voorwaarden-Dolphiq-Mei-2018.pdf.

johanzandstra commented 3 years ago

@gbowne-quickbase Just merged this.

gbowne-quickbase commented 3 years ago

Iā€™m so excited! This is great, thanks

Greg Bowne Pronouns: he/him Software Engineering Manager 150 Cambridgepark Drive Cambridge, MA 02140 QuickBase.com

From: Johan Zandstra @.> Sent: Friday, April 9, 2021 7:01:43 AM To: Dolphiq/craft3-plugin-sitemap @.> Cc: Bowne, Greg @.>; Mention @.> Subject: Re: [Dolphiq/craft3-plugin-sitemap] Composer 2 compatibility fix (#57)

@gbowne-quickbasehttps://github.com/gbowne-quickbase Just merged this.

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Dolphiq/craft3-plugin-sitemap/pull/57#issuecomment-816603079, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJKBWVCSSRBANYPNMWRSNZLTH3NBPANCNFSM4TA2JYOA.

This message and its contents are confidential. If you received this message in error, do not use or rely upon it. Instead, please inform the sender and then delete it. Thank you.