search

Dolu89 / ligess

Personal Lightning address server
53 stars 13 forks source link

Support private routing hints #7

Open seth586 opened 1 year ago

seth586 commented 1 year ago

Right now, inbound liquidity on a private channel will not work unless a private routing hint is added.

sommerfelddev commented 1 year ago

According the lnd rest api docs for AddInvoice it seems to be as easy as adding private=true in the rest api request.

According to my shallow investigation, it should be added in these places:

https://github.com/Dolu89/ligess/blob/d8c71626a403a5d40f6f88b134506d7776a34d3a/router.js#L47-L53

https://github.com/blc-org/una/blob/c4ae26440081b29f8a0f3b950a1be948dc9cb872/bindings/una-js/index.d.ts#L22-L32

Maybe this should be behind an environment variable like LIGESS_LND_PRIVATE_INVOICES. @Dolu89 what do you think?

Dolu89 commented 1 year ago

Ligess currently uses the original node.js of Una (master branch). This https://github.com/blc-org/una/blob/c4ae26440081b29f8a0f3b950a1be948dc9cb872/bindings/una-js/index.d.ts#L22-L32 is part of the new version of Una written in Rust. It's not finished, so not deployed yet.

The current node.js version of Una wasn't supposed to be updated, but I'll see how to add this later