search

DomBlack / php-scrypt

A PHP wrapper fo the scrypt hashing algorithm
Other
208 stars 57 forks source link

Allowed memory exhausted error on Windows #17

Closed weltling closed 11 years ago

weltling commented 11 years ago

Haven't tested on linux yet, but Windows + PHP 5.4 has this issue

`echo scrypt('pleaseletmein', 'SodiumChloride', 1048576, 8, 1, 64);"

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 1073741824 bytes) in Command line code on line 1`

That's the last line from the vectors.phpt.

Parent5446 commented 11 years ago

This is not a bug. Scrypt uses a lot of memory. Naturally if you increase the amount of memory it uses beyond certain limits it will cause memory exhaustion. Unless you're proposing that the error be handled differently, i.e., maybe it doesn't trigger a fatal error but something else.

weltling commented 11 years ago

Agree, this works

nmake test TESTS=" -n -d extension_dir=Release_TS -d extension=php_scrypt.dll -d memory_limit=2G ext\scrypt"

Previously i was setting memory_limit=1G and that's failed. So great, issue fixed :)

weltling commented 11 years ago

actually, vectors.phpt should have the right memory_limit set in --INI-- section, to avoid that confusion.