DomBlack / php-scrypt

A PHP wrapper fo the scrypt hashing algorithm
Other
209 stars 57 forks source link

fix mem leak on PHP 7 #48

Closed remicollet closed 8 years ago

remicollet commented 8 years ago

With PHP 7 RETURN_STRINGL always allocate new space (no more 3rd arg, aka copy), need to be freed.

DomBlack commented 8 years ago

@remicollet thanks again for this (I'm not a PHP 7 user myself)

Anything else I should look out for with the change to PHP 7 or am I ok to release 1.4.2 to PECL?

remicollet commented 8 years ago

@DomBlack I just add a second "cleanup" commit, nothing critical

Old things

remicollet commented 8 years ago

And, BTW, after a quick look, I think everything is ok for a 1.4.2 release ;)

remicollet commented 8 years ago

BTW, do you plan to release 1.4.2 soon, or wait a little for more feedback (from other users) ?

P.S. just to know if I push 1.4.1 to my RPM repository or wait for 1.4.2

DomBlack commented 8 years ago

I just published 1.4.2, was waiting for feed back on #44 and included the fix in the 1.4.2 release.

remicollet commented 8 years ago

Thanks