search

DomT4 / homebrew-autoupdate

:tropical_drink: An easy, convenient way to automatically update Homebrew.
BSD 2-Clause "Simplified" License
1k stars 55 forks source link

Enhance output of status command #113

Open swissbuechi opened 10 months ago

swissbuechi commented 10 months ago

Solves issue: https://github.com/Homebrew/homebrew-autoupdate/issues/38

image
swissbuechi commented 10 months ago

Accidentally deleted wrong branch...

swissbuechi commented 10 months ago

I added the output of the new --sudo argument:

image

github-actions[bot] commented 8 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

DomT4 commented 8 months ago

Is there any appreciable slowdown in the command invocation in pulling the additional information? Beyond that question and this needing rebasing, no objection though. Makes enough sense to me. Apologies for the slow review on these.

swissbuechi commented 8 months ago

Apologies for the slow review on these.

No need to apologize, I've literally spammed you with PR's...


Is there any appreciable slowdown in the command invocation in pulling the additional information?

No, the XML is parsed within milliseconds and the command output still immediately displays on my M1 Pro.


this needing rebasing

Yes, I know. All of a sudden, there was an issue with the required import for the XML parsing:

Error: cannot load such file -- rexml/document - in status.rb line 3

It worked just fine a few weeks ago. I will now try to implement the XML parsing in native ruby or maybe fix the dependency import.

github-actions[bot] commented 8 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

DomT4 commented 8 months ago

Relax robot. Will set aside some time tomorrow to review again.

Did we manage to solve the XML loading issue?

swissbuechi commented 8 months ago

I haven't figured out yet how I can import a dependency in the gemfile.

Seems like there is no gemfile because homebrew-autouodate is just an add-on module?

I really don't understand ruby and the whole homebrew project well enought.

Will try to understand both a little better and fix the issue.

github-actions[bot] commented 7 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

swissbuechi commented 7 months ago

not stale