search

DomT4 / homebrew-autoupdate

:tropical_drink: An easy, convenient way to automatically update Homebrew.
BSD 2-Clause "Simplified" License
987 stars 54 forks source link

Do not use `--greedy` by default #58

Closed jaklan closed 2 years ago

jaklan commented 3 years ago

This commit introduced --greedy flag always when using --upgrade option:

https://github.com/Homebrew/homebrew-autoupdate/blob/24c4193f89280b3ec38722010623ae2971dc5072/lib/autoupdate/start.rb#L17-L21

It shouldn't be the default behaviour, for the same reasons it's not default for brew (as described in brew docs).

Solution? E.g. additional flag: --greedy-upgrade.

DomT4 commented 3 years ago

This seems a valid enough request to me. I'd accept a PR to add a flag & related code changes, or I can try and look at it myself hopefully Sunday sometime.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

mlegenhausen commented 2 years ago

This option seems to make trouble with the google-cloud-sdk package. It seems that during the update this package gets partially removed and is broken afterwards only a reinstallation via brew reinstall -f google-cloud-sdk solves the problem. Removing --greedy solved the issue for now.

I am using brew autoupdate --start --upgrade --cleanup.

erikw commented 2 years ago

I completely agree. Every day Firefox.app is shut down while I use it because it's being upgraded due to --greedy. Firfox is a self-updating app and does not needs to be autoupdated by this tool.

--greedy should be opt-in for homebrew-autoupdate!

erikw commented 2 years ago

I think something as simple as #81 can fix this issue 😃