search

Domain-Connect / spec

Domain Connect Specification
MIT License
73 stars 34 forks source link

NEW FEATURE: variables in number fields #100

Open pawel-kow opened 4 months ago

pawel-kow commented 4 months ago

Adresses issue #88

pawel-kow commented 4 months ago

@kerolasa @lianapanatau-ionos @wdbaker-godaddy please take look here as well if this update makes sense to you

kerolasa commented 3 months ago

Just to be explicit the string-number-variables can be expressed in template three different ways, and these need to be equal (assuming variable expansion results to same numeric value). 

"ttl": 3600
"ttl": "3600"
"ttl": "%var%"

After a template is processed the value MUST to be numeric. I think that's right, right?

pawel-kow commented 3 months ago

@kerolasa correct. Is there any edit to the text needed to make it clear?

kerolasa commented 3 months ago

The Int or string representation of Int is probably good enough. I will try to make dc-template-linter to work with int-string-variables sometime soon(ish).

jkolker-godaddy commented 1 month ago

I have reviewed with DEV and they will approve the pull request.