Closed rlees85 closed 5 months ago
rlees85
commented
6 months ago I think this is about as far as I can take it. Please do suggest any improvements. The toggle seems to work. I'd also like to change the icon to the bell with maybe a cross in it or something but I don't know where you got your icon set from.
Domi04151309
commented
6 months ago The icons are from here https://fonts.google.com/icons?icon.set=Material+Symbols&icon.size=24&icon.color=%23e8eaed&icon.style=Rounded. Your changes look good, however I was thinking about making stopping at zero notifications the default behavior for ambient mode and not make it toggleable. What do you think about that?
rlees85
commented
6 months ago The icons are from here https://fonts.google.com/icons?icon.set=Material+Symbols&icon.size=24&icon.color=%23e8eaed&icon.style=Rounded. Your changes look good, however I was thinking about making stopping at zero notifications the default behavior for ambient mode and not make it toggleable. What do you think about that?
It would be fine by me honestly. Its just the screen lighting up behaviour when the AOD gets dismissed some people might find a bit weird but honestly so is keeping the AOD when there are no notifications left.
More than happy to remove the setting preference however.
rlees85
commented
5 months ago Updated PR
Fixes: https://github.com/Domi04151309/AlwaysOn/issues/85 (sort-of)
See in particular this comment: https://github.com/Domi04151309/AlwaysOn/issues/85#issuecomment-1785694172
This is work in progress and it should probably be put behind a setting. Feel free to commit to this PR or to clone it and carry on. I will however try and get round do it and finish it off but as said before Android development isn't a strong point of mine.
Also the commit history is fairly bad as I had fun rebasing from the new "main" branch so it will want squashing when merging!