Make Shelly response parsing unit-testable

Domi04151309 / HomeApp

HomeApp is a small and easy to use smart home app with a simple framework.

https://f-droid.org/packages/io.github.domi04151309.home/

GNU General Public License v3.0

106 stars 24 forks source link

Make Shelly response parsing unit-testable #44

Closed cweiske closed 2 years ago

cweiske commented 2 years ago

Related: #27

cweiske commented 2 years ago

I've added power meter, temperature and humidity reading for Shelly 1 devices. It was a breeze. I don't have a shelly1 with temperature sensor myself, but a friend only sent his status json to me and I could implement it safely with the tests.

Domi04151309 commented 2 years ago

I modified the code a bit. Can you verify that everything still works as intended?

cweiske commented 2 years ago

Tests run. My Shelly Plug S also still shows the current wattage. All fine!