Shelly & ESP Easy real time status

Domi04151309 / HomeApp

HomeApp is a small and easy to use smart home app with a simple framework.

https://f-droid.org/packages/io.github.domi04151309.home/

GNU General Public License v3.0

106 stars 24 forks source link

Shelly & ESP Easy real time status #64

Closed Domi04151309 closed 2 years ago

Domi04151309 commented 2 years ago

Adds the real-time status functionality from the Hue API to Shelly and ESP Easy devices.

This makes the app check for state changes every second so that you can switch states with another device and still have an accurate representation of the real states on your own device.

Can you perform simple testing on real devices? @cweiske

[x] Switch state changes when updated from the web interface
[x] Scroll position stays the same
[x] Dynamic summary updates
[ ] Power meter values

cweiske commented 2 years ago

I can only test shelly devices:

ok: The switch state changes when I change the switch from the shelly's web interface
ok: The scroll position stays the same when switch data are updated
not ok: The subline "Der Schalter ist an" does not change
not ok: The power metering values do not get updated.
not ok: When changing to landscape mode, I'm back at the main device list and do not stay in the currently selected device. (This is probably unrelated to this branch here)

znbrain commented 2 years ago

I tested it with ESPEasy devices.

ok: The switch state changes when I change the switch from the shelly's web interface
not ok: The subline "Der Schalter ist an" does not change

not ok: https://github.com/Domi04151309/HomeApp/issues/63#issuecomment-1006088768 This also can be a seperate issue

Domi04151309 commented 2 years ago

@cweiske the reset when changing orientation should be fixed on the master branch. Can you verify that dynamic summaries work with the latest commit on this branch?

cweiske commented 2 years ago

I rebased this feature branch against master, and the orientation change problem is gone.
The "Der Schalter ist an" status line gets updated.

So far that's ok.

Why do you introduce a new method for fetching updated data? Can't HomeApp simply call the normal device status method and update all the existing list items from the returned listitems?

Domi04151309 commented 2 years ago

It calles a new method so that possible simplifications can be implemented to save some energy since this method will be called a lot. Also it updates the data a bit more smoothly compared to completely updating the whole list.

cweiske commented 2 years ago

I wouldn't replace the whole list (which causes scroll position continuity problems) but only update the data of the visible list items from the api's newly generated list items.