search

Domi04151309 / HomeApp

HomeApp is a small and easy to use smart home app with a simple framework.
https://f-droid.org/packages/io.github.domi04151309.home/
GNU General Public License v3.0
106 stars 24 forks source link

[Bug Report] Socket device icon looks bad #66

Closed cweiske closed 2 years ago

cweiske commented 2 years ago

Description The socket device icon in blue looks ugly on a white background. The original one from #58 looked better in my eyes.

I presume you did that change because of white/dark themes. Could there be an inverted one for the dark theme instead of using the blue one?

Screenshot_20220107-185556_Home

Domi04151309 commented 2 years ago

All the current icons use the colored icon style with adjusted colors to match the fluent icon style. I would like to use a colorful icon here as well. Feel free to suggest different fill colors for the icon. You can find the current icon on Icons8.

cweiske commented 2 years ago

I like the icon that I selected originally most (#58), because the wall sockets actually look that way here. They are white and not blue, and the black outline makes sense.

Domi04151309 commented 2 years ago

What do you think about the different colors in the latest commit. Your icon uses another icon style. I would like to use icons from the same style for consistency.

cweiske commented 2 years ago

We're talking about https://icons8.com/icon/7283/wall-socket and the icon styles "iOS" and "color", presumably with modified colors.

I don't see why we need a colored icon for a socket that is white in most houses. Also, the "color" style of the wall socket icon is missing the nice rounded border that the iOS variant has.

But I'm tired discussing this. Feel free to close the issue without changes.