Dominic-DallOsto / zotero-reading-list

Keep track of whether you've read items in Zotero
GNU General Public License v3.0
297 stars 7 forks source link

Automatically set a matching tag when setting an item's read status #39

Open Dominic-DallOsto opened 4 months ago

Dominic-DallOsto commented 4 months ago

Fixes #8

What happens when adding custom read statuses?

github-actions[bot] commented 4 months ago

:rocket: This ticket has been resolved in v1.4.0-beta. See Release 1.4.0-beta for release notes.

github-actions[bot] commented 3 months ago

:rocket: This ticket has been resolved in v1.6.0-beta.0. See Release 1.6.0-beta.0 for release notes.

MaxVonMustermann commented 3 months ago

I tested beta version 1.60-beta0 and the foundation is there now! Great work. One additional idea: Read status regarding columns features an emoji-only mode, text+emoji or only text. Since tags also support emojis, this functionality would be highly appreciated, if added to tags as well (especially an "emoji-only" setting). Thank you!

Dominic-DallOsto commented 3 months ago

I tested beta version 1.60-beta0 and the foundation is there now! Great work. One additional idea: Read status regarding columns features an emoji-only mode, text+emoji or only text. Since tags also support emojis, this functionality would be highly appreciated, if added to tags as well (especially an "emoji-only" setting). Thank you!

Ahh, does applying a tag with an emoji also cause the emoji to appear in front of the item's title on the app, like it does in desktop Zotero?

MaxVonMustermann commented 3 months ago

I tested beta version 1.60-beta0 and the foundation is there now! Great work. One additional idea: Read status regarding columns features an emoji-only mode, text+emoji or only text. Since tags also support emojis, this functionality would be highly appreciated, if added to tags as well (especially an "emoji-only" setting). Thank you!

Ahh, does applying a tag with an emoji also cause the emoji to appear in front of the item's title on the app, like it does in desktop Zotero?

Yes, it does.

github-actions[bot] commented 2 months ago

:rocket: This ticket has been resolved in v1.6.0-beta.1. See Release 1.6.0-beta.1 for release notes.

Dominic-DallOsto commented 2 months ago

@MaxVonMustermann I added the option of including emojis in tags in the latest beta, so you can see the read status emojis in front of the items titles. See what you think!

I didn't add an option to only use emojis and no text for the tags because we don't enforce that there's a unique emoji for each read status, so it might not be possible to uniquely determine the read status from just the emoji. I think I'd prefer to leave it like this, so users have the flexibility to have two read statuses with the same emoji if they want, unless you have a strong use case for emoji-only tags?

MaxVonMustermann commented 2 months ago

@MaxVonMustermann I added the option of including emojis in tags in the latest beta, so you can see the read status emojis in front of the items titles. See what you think!

I didn't add an option to only use emojis and no text for the tags because we don't enforce that there's a unique emoji for each read status, so it might not be possible to uniquely determine the read status from just the emoji. I think I'd prefer to leave it like this, so users have the flexibility to have two read statuses with the same emoji if they want, unless you have a strong use case for emoji-only tags?

Thank you, it works well! I assume this is a limitation from Zotero's side that adding emojis to tags will cause emojis to always appear in the title of the parent file? This is, nevertheless, not too bad, since you can hide the dedicated read status column to prevent wasting space. I see your point regarding "emoji only" tags.

Edit: having the emojis in front of the title is aboslutely fantastic for iOS use cases. It's like having the plugin installed on iOS, with the reading status being visible there as well. Brilliant job!!

Dominic-DallOsto commented 2 months ago

Yeah, I don't think it's possible to disable showing the emojis in front of the item titles. (edit: it might work by overwriting this function to always return false - https://github.com/zotero/zotero/blob/4c04dc583e3b74f4dcb7fdf50ae46f6c17c1a3a3/chrome/content/zotero/xpcom/utilities_internal.js#L399 - but I'd have to check if that won't have unintended consequences for anywhere else it's used)

But good to hear it works nicely on iOS! Thanks for testing!

Actually, does it work for you to not use icons at all, but to make the status names emojis instead of text? That might work as a workaround to have emoji only tags?

MaxVonMustermann commented 2 months ago

Yeah, I don't think it's possible to disable showing the emojis in front of the item titles.

But good to hear it works nicely on iOS! Thanks for testing!

Actually, does it work for you to not use emojis at all, but the make the status names emojis instead of text? That might work as a workaround to have emoji only tags?

You're welcome. Well, it works with a limitation. The "emoji-only" tag is shown in front of the name and on the iPad as well. On the iPad, it is also shown in the tag list, which isn't the case on the Mac app. There, the limitation is that the "emoji-only" tag does not appear in the tag list (left pane) at all.

Dominic-DallOsto commented 2 months ago

Hmm, it works for me on Windows, but I had to manually update all the item's read statuses from their text to their emoji versions

image

But yeah, this will still show the emoji in front of the title because I think Zotero does this whenever there's an emoji in the tag

github-actions[bot] commented 1 month ago

:rocket: This ticket has been resolved in v1.6.0-beta.2. See Release 1.6.0-beta.2 for release notes.