search

DominicFuMJ / pe

0 stars 0 forks source link

addavail incorrect command sometimes does not delete input #6

Open DominicFuMJ opened 4 months ago

DominicFuMJ commented 4 months ago


video:https://raw.githubusercontent.com/DominicFuMJ/pe/main/files/574837a3-7938-49b8-8cf3-5a2f63c40ac9.mp4

Steps: 1. I used 'find a/01/03/2024' which display Alex Yeoh and Charlotte Oliveiro.

  1. I used 'addavail 1 a/05/05/2024' , adding the availability 05/05/2024 to Alex
  2. I used 'find a/01/03/2024' again.
  3. I used 'addavail 2 a/05/05/2024', adding the availability 05/05/2024 to Charlotte
  4. I used 'list'
  5. I used 'addavail 1 a/05/05/2024' and it displayed the duplicate error and remove the input
  6. I used 'addavail 3 a/05/05/2024' and it displayed the duplicate error but does not remove the input.
  7. I used 'addavail 2 a/05/05/2024' to add 05/05/2024 to Bernice Yu, then used 'addavail 2 a/05/05/2024' again and got the duplicate error and it removed the input.

Only the 'addavail 3 a/05/05/2024' is not removed when I run it.

nus-se-script commented 4 months ago

Team's Response

Similar to this issue, it is due to autocomplete's implementation, not regarding command.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Command line deletes command if nothing is in front of it, but keeps the command if something is inputed as well


video:https://raw.githubusercontent.com/nus-cs2103-AY2324S2/pe/master/files/da6aa9c2-2740-4ec7-a0f6-d97da0f0ccfa.mp4

When I try the command 'add', it would display the error and deletes the incorrect input. If I try 'add n/asas', it would display the error and keep the incorrect input. Recommendation: Either have the input always be removed, or always kept.

[original: nus-cs2103-AY2324S2/pe-interim#822] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for your feedback. We have cleared the command because it already exists in the command history. This was designed as the deleted command can be easily retrieved from the command history. However, we also recognize the possible confusion that this behavior might cause and should have standardized the response.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]