search

DominicFuMJ / pe

0 stars 0 forks source link

Manual edit of the addressbook.json will cause it to be deleted upon running the application again #7

Open DominicFuMJ opened 6 months ago

DominicFuMJ commented 6 months ago

Before Data Edit, I open the application with a fresh addressbook.json

image.png

image.png

Editing the data to add '[ "Food Bank", "Teaching" ]' to the tag for Charlotte. image.png

After data edit and reopening the application, the application deletes all the data and when I exit the application, the addressbook.json is shown to be empty. image.png

image.png

Note: It also happens when I try to edit the email, name, phone number or availability.

The data is not deleted when I manually edit the assignments, only deletes when I manually edit the person.

nus-pe-bot commented 5 months ago

Team's Response

Hi it is mentioned in our user guide that any modifications of the json file with invalid data will wipe the data within it. Please refer to the screenshot below.

image.png

To edit the json, you need to edit BOTH "Person" AND "Assignment" details as follow:

image.png

image.png

The above changes result in successful updates in the app:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The edit the data file doesn't really state that you must edit both the persons and assignment in order to change it manually in the data file. This lack of documentation may cause users to try and repeat the same error again. I will accept that the severity would be low, but I believe this is still an error, just now a documentation error instead.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]