DominicMaas / TimelineExtension

Windows Timeline & Project Rome Web Extension
MIT License
483 stars 27 forks source link

Only saves one site of visited domain #93

Open akosnad opened 5 years ago

akosnad commented 5 years ago

First of all, thank you for your work, this extension is very useful.

My only issue is, if I visit a domain, it saves the site for the first time. But when I click on links, and navigate inside the same domain, it does not appear on my timeline, only the first visited site of the said domain. For example, if I go on YouTube, watch some videos, then I can only see one entry on my timeline, which is the first video that I watched. And I know it is not the 8 second delay before the extension pushes to the timeline, because I spent more time watching each video for more than 8 seconds.

I don't know if this is intentional. Maybe, there could be an option to send all pages that I visited for certain domains, and not others. Or have an option globally.

I use Chromium 71.0.3578.98 on Windows, plugin version 1.0.4.

DominicMaas commented 5 years ago

This will only happen on some sites (YouTube is one of them), the reason is below:

When you click on a link on YouTube, it doesn't actually navigate to a new page, it instead updates the url, title, and changes the content without reloading everything. Since the extension listens for page loads, navigating around YouTube won't save anything to your Timeline.

I'm sure there is a way to detect these fake loads (like url changing), MS Edge does it. I'll leave this issue open so I can come back to it later and try fix it.

Thanks for the kind words!