search

DominicMaas / TimelineExtension

Windows Timeline & Project Rome Web Extension
MIT License
482 stars 27 forks source link

Firefox says that ssl sertificates are invalid #98

Closed survivor303 closed 4 years ago

survivor303 commented 5 years ago

So is this addon secure anymore?

DominicMaas commented 5 years ago

AFAIK this addon is not currently published to the FireFox store (kept having issues, needs to be updated anyway sometime).

d1vanloon commented 5 years ago

Looks like the described issue is during the Microsoft Account callback... tries to navigate to https://timeline.dominicmaas.co.nz, which seems to no longer exist.

DominicMaas commented 5 years ago

Oh I see, I moved that domain to a different DNS provider about a week ago, must have broken it. Let me take a look.

Ideally I'd change the Auth system to not require a redirect url like that (I had issues with the oauth flow and requiring refresh tokens).

DominicMaas commented 5 years ago

Ahh, cloudflare applied auto HTTPS, I need to enable it on GitHub pages.

DominicMaas commented 5 years ago

Okay that should be fixed now

d1vanloon commented 5 years ago

The issue seems to be resolved from my perspective.

DominicMaas commented 5 years ago

Awesome, how about @survivor303?

survivor303 commented 5 years ago

I think it is fixed because you dudes say so. I havent tested it yet ;) i test it later today.