DominicWatts / CustomerInfo

Magento 2 additional info on admin customer grid - last logged in and last order date
1 stars 0 forks source link

Error when filtering on Magento 2.3.6 #2

Open paul-blundell opened 3 years ago

paul-blundell commented 3 years ago

This extension appeared to work great when I first installed it however when you try and filter by anything or search a keyword Magento throws an error:

Something went wrong with processing the default view and we have restored the filter to its original state.

I think this might be related to 2.3.6 as I am sure it was working before the update but not 100%.

Any ideas how to fix?

drinkingsouls commented 2 years ago

Same issue, Magento 2.4.3. Is there a fix for this?

DomPixie commented 2 years ago

No sorry but feel free to submit a pull request if you figure something out

drinkingsouls commented 2 years ago

Apply Magento patch MDVA-37364 to fix this issue. Included in quality patches.

DominicWatts commented 2 years ago

Finally got round to checking this. Works okay for me in vanilla Magento ver. 2.4.3-p1

@drinkingsouls This the patch yes?

https://github.com/magento/quality-patches/blob/master/patches/os/MDVA-37364_2.4.2.patch

diff --git a/vendor/magento/module-ui/view/base/web/js/grid/columns/date.js b/vendor/magento/module-ui/view/base/web/js/grid/columns/date.js
index 88959cda749..29a589b20f7 100644
--- a/vendor/magento/module-ui/view/base/web/js/grid/columns/date.js
+++ b/vendor/magento/module-ui/view/base/web/js/grid/columns/date.js
@@ -48,7 +48,7 @@ define([

             date = moment.utc(this._super());

-            if (!_.isUndefined(this.timezone)) {
+            if (!_.isUndefined(this.timezone) && moment.tz.zone(this.timezone) !== null) {
                 date = date.tz(this.timezone);
             }
DomPixie commented 2 years ago

Tested on 2.3.6

image

83krynio commented 1 year ago

2.4.6-p3 not working. Issue connected with admin search.

Any Idea how to fix it?