Bug fix + upgrades - Githubissues

DominikGuzei / flawless.css

A full stack html5 and css3 framework that uses less.js as it's core to provide a truly modular system with addons and other cute stuff ;-D

MIT License

184 stars 11 forks source link

Bug fix + upgrades #7

Closed superstructor closed 13 years ago

superstructor commented 13 years ago

Fixed minor bug that caused demo page (index.html) to be completely broken in IE due to 404 file not found for PIE.txt.htc file. Some components of the famework setup path where repeated twice.

Also upgraded JavaScript libraries to the latest versions.

DominikGuzei commented 13 years ago

Hey, that's nice!

I quickly scanned the changes -> There might be a problem with the update to newest less.js since I hacked some improvements for flawless.css into the less.js core (you can see them highlighted by your commit changes)

My hackery summed up:

Caching: I changed the core to be able to cache all files / flawless core only / none files
Force development environment
Incept own less.js functions - I had to wrap the less.js startup into my own init function to add custom functions to less.js

hope this helps :-) Maybe I find some time next week! kind regards

superstructor commented 13 years ago

Hey Dominik,

Thanks for your fast reply and useful infos. I missed the changes to less.js core. After upgrading I had went on to add some functions and after looking at less.js core was wondering how adding your own functions had ever worked... ;-)

I have re-added the same lines and appears to work fine.

Best regards

superstructor commented 13 years ago

Hey Dominik,

Sorry I re-wrote my local history to update my email address etc so have deleted my fork as you can't push re-written history. I'll re-fork and re-push all my changes as soon as github allows me to then open a new pull request.

Apologies for the inconvenience. Wanted to get this done before my commits make it into other peoples history.

Best regards