DominikPieper / obsidian-ReadItLater

MIT License
443 stars 35 forks source link

Cancel auto-play of embedded bilibili videos #102

Closed Ce1este closed 1 year ago

Ce1este commented 1 year ago

⚠️ Please check that this feature request hasn't been suggested before.

πŸ”– Feature description

Embedded Bilibili videos will play automatically, and videos in reading mode and editing mode will play simultaneously.

βœ”οΈ Solution

It gets worse when I preview a lot of pages with bilibili embedded videos at the same time. So I want the embedded bilibili video not to play automatically when I open the page.

❓ Alternatives

Add "&autoplay=0" to cancel auto-play For example:

<iframe width="${this.settings.bilibiliEmbedWidth}" height="${this.settings.bilibiliEmbedHeight}" src="https://player.bilibili.com/player.html?bvid=${n}&autoplay=0" scrolling="no" border="0" frameborder="no" framespacing="0" allowfullscreen="true"></iframe>

πŸ“ Additional Context

I'm not sure if anyone needs the video autoplay feature when opening the page. Maybe make a button in the settings page to switch this setting on and off?


(And Thank you for creating the plugin, it helped me a lot.)

adamluckdev commented 1 year ago

Thanks for the report.

There's no need to create setting for enabling autoplay. As you mentioned, autoplay of embedded content causes only complications.