DominikPieper / obsidian-ReadItLater

MIT License
450 stars 35 forks source link

Instagram link unreadable and nothing is saved #164

Closed jgroeneveld closed 2 months ago

jgroeneveld commented 3 months ago

Please check that this issue hasn't been reported before.

Expected Behavior

The link is saved as usual, at least as a plain link.

Current behaviour

I see the message @mozilla/readability considers this document to unlikely be readerable. and nothing is saved

Steps to reproduce

Paste https://www.instagram.com/reel/C-w3D8BMvsh/ either on mac or iphone

Which Operating Systems are you using?

Obsidian Version

Version 1.6.7

Plugin Version

0.5.0

Checks

Possible solution

No response

sims5487 commented 3 months ago

I'm also having this same issue, but just not with Instagram URLs - anything that is classified as "unreadable" doesn't seem to be saving. I first noticed the issue with this URL: https://obsidianttrpgtutorials.com/Obsidian+TTRPG+Tutorials/Getting+Started/Getting+Started

I'm also receiving the "@mozilla/readability considers this document to unlikely be readerable." message in Obsidian when pasting.

I also tried it with an Instagram URL and got the same result.

This isn't working for me on Mac, Windows, or iPhone. I'm also using OBsidian 1.6.7 and ReadItLater 0.5.0

DominikPieper commented 3 months ago

The plugin uses Mozilla readability as the reading formatted. It’s one of the core packages to prepare the page. We have to take a look but if it’s a problem with the lib itself it’s hard to fix

adamluckdev commented 3 months ago

This problem occurs mainly with websites that use Javascript to render content. Both Instagram and obsidianttrpgtutorials.com belongs to this category.

However there is a bug which prevents from saving note with URL of non-parseable site.

Thanks for the report.

adamluckdev commented 3 months ago

Saving of non-parseable article fixed in #165 and will be included in next release.