Closed TymekDev closed 4 years ago
Ditto:
plot_dependencies(deepdep('tidyverse', 5L), 'circular')
Finally I've found enough time and motivation to dig into this problem! It turns out that it was caused by two independent factors:
deepdep
function did not correctly mark packages about which it had already downloaded information, so for more complex dependency networks loops appearedBoth bugs have been fixed in commits 355bc0c93dc97f86c001105340cec74a174e0b42 and e3a826c9b691db9d440edbd6742c6a3b8cfbe16f . Now it works as it should:
Describe the bug When using
plot_dependencies
withdepth
argument too high (or ondeepdep
results created with too high argument) an unhandled error is thrown. I suspect this happens whendepth
is higher that maximum graph depth, e.g. package has dependencies which doesn't have any "subdependencies" anddepth = 2
will throw this error.On the other hand when package has no dependencies it works just fine.
How to reproduce? Steps to reproduce the behavior:
What works:
Expected behavior Expected the dependencies to plot regardless of whether the
depth
was higher than the dependency tree or not.Screenshots
Session info