DominikRafacz / deepdep

Visualise and Explore Deep Dependencies of R packages
https://dominikrafacz.github.io/deepdep/
GNU General Public License v3.0
73 stars 8 forks source link

`plot_dependencies()` doesn't work with the latest `{igraph}` #51

Closed IndrajeetPatil closed 1 year ago

IndrajeetPatil commented 1 year ago

Looks like {igraph} update on CRAN has broken {deepdep}:

https://cran.rstudio.com/web/checks/check_results_deepdep.html

szhorvat commented 1 year ago

This is due to the intentional breaking change noted in igraph's NEWS file:

https://cran.r-project.org/web/packages/igraph/news/news.html

When setting vertex or edge attributes, the number of values supplied must now exactly match the number of vertices or edges.

Previously, recycling was used to fill out the missing elements.

ErdaradunGaztea commented 1 year ago

Ooops! Thanks for the details, sounds like we have some bad coding practices on our hands.

DominikRafacz commented 1 year ago

This issue is closed in 0.4.2 version. It has already been submitted to CRAN, should be published soon