search

DominikSerafin / vuebar

(🗃️ Archived) Vue 2 directive for custom scrollbar that uses native scroll behavior. Lightweight, performant, customizable and without dependencies. Used successfully in production on https://ggather.com
https://github.serafin.io/vuebar/
MIT License
649 stars 77 forks source link

Fixed max-height issue #60

Closed georgek901 closed 4 years ago

georgek901 commented 6 years ago

It fixes the issue of https://github.com/DominikSerafin/vuebar/isses/30) with flexbox

martinsnajdr commented 6 years ago

This PR should be accepted. Not working max-height is a dealbreaker, because most of the time you specify max-height, so if the element is not bigger than (n)px, the scrollbar is not visible. With height only working you have to have fixed height.

DominikSerafin commented 6 years ago

Hey @martinsnajdr, I'll look into merging this into Vuebar 2.0. Vuebar 0.0.18 is kinda freezed right now and I don't think I'll be pushing any new updates for it due to limited time I have to work on open source.

2.0 is almost ready, I just need to make some last polishes, etc., but again - I didn't have time to do that in recent months.

If you're interested or adventurous, you can check it on development branch.

(If you really need this working with Vuebar, you can just fork this repo & merge this PR on your own and then use your own version - it's not perfect, but it will work).

nburic commented 6 years ago

Hey @DominikSerafin. We are using your directive in our project which needs horizontal scroller and setting minimum and maximum dragger height. I can see you have introduced it in 2.0 and you said it is going to be released soon. Can we expect your release until the end of September? If not what would be the best workaround to find those features as soon as possible? Thanks for your answers and for your amazing directive!

DominikSerafin commented 6 years ago

@iambaboon I don't think I'll be able to release 2.0 by the end of September. As for workaround I can suggest taking out the WIP Vuebar 2.0 from "development" branch and using that code. It's pretty usable already when it comes to horizontal scrolling. The only disadvantages are that it's undocumented & unstable (API/design might change in future). But there are plenty of demos in the index.html file.

DominikSerafin commented 5 years ago

https://github.com/DominikSerafin/vuebar/issues/84