Users/justin.pumford/update tools

DomoApps / advanced-sample-app

An advanced sample custom app design built with starter-kit

MIT License

11 stars 6 forks source link

Users/justin.pumford/update tools #28

Open jpumford opened 7 years ago

jpumford commented 7 years ago

Enjoy!

jpumford commented 7 years ago

@bmbarker90 it's just an update-tools

jpumford commented 7 years ago

@sldavidson Yeah, I thought about the redux stubs! I left them because I was worried removing them would make other update-tools pretty complicated, especially if we modify those stubs on generator. It's up to you; I can remove the stubs if you'd like.

jpumford commented 7 years ago

@sldavidson As far as angular-animate goes, should it be added as an external to starter-kit as well, considering it is external? We could run into the same issue

jpumford commented 7 years ago

@sldavidson alright, that's been updated! Let me know what your thoughts are about the redux stubs.

sldavidson commented 7 years ago

It might confuse people who are looking at the code and see stubbed out code.

jpumford commented 7 years ago

@sldavidson yes, that's because I made the PR when Jake was having issues with cross-env. If you'd like I can add that to this one as well, I just wanted to split up as much as possible (though this PR is still a mess... update-tools is going to have to change)