search

DomoApps / starter-kit

This is an advanced Domo App project starter (boilerplate).
MIT License
20 stars 9 forks source link

package.json build script places files incorrectly #60

Closed jpumford closed 7 years ago

jpumford commented 8 years ago

From @hut8:

Minor issue: running npm run build, which is:

rm -rf ./dist && NODE_ENV=production ./node_modules/.bin/webpack && cp -r domo/ dist/

results in the dist folder containing a domo folder, which contains the thumbnail and manifest.json. Another script, upload, has:

npm run build && cd dist/ && domo publish && cd ..

Because manifest.json is in dist/domo and not just dist/, that ends up causing this error:

X No manifest.json file in this directory
Please publish from a directory containing a Custom App design manifest.json file

Perhaps the build script could just run cp domo/* dist/ instead?

jpumford commented 8 years ago

@hut8 So after looking at the issue a bit, it could be an environment thing that we'll have to fix. On OS X the cp command actually will copy over the contents of domo to dist. What OS are you running/which environment is the npm build command running in?

hut8 commented 8 years ago

Hey! Sorry I somehow missed the notification for this. I'm on Linux (Ubuntu Xenial 16.04).

jpumford commented 8 years ago

I've created a pull request which has fixed it on our linux machines. Let me know how that works and I'll get it in advanced-sample-app as well.

hut8 commented 7 years ago

This can be closed 😄 Thanks for fix.