search

Domysee / BittrexSharp

C# Api Wrapper for Bittrex
MIT License
30 stars 16 forks source link

RATE_NOT_PROVIDED #11

Closed marnixbent closed 7 years ago

marnixbent commented 7 years ago

On my machine, decimals are noted with comma's instead of dots. Comma's get URL-encoded, that means an invalid rate value is sent to bittrex and that causes the RATE_NOT_PROVIDED error message.

Simple fix here is to replace the comma's to dots in the param values. I'll create a PR shortly.

Domysee commented 7 years ago

Thank you for the pull request. While it is a viable solution, and the one with the fewest changes necessary,, it would be better to use the English locale for every number to string conversion. That way, it is still possible to have commas in the parameters. I'm working on that right now, and will commit it as soon as it is finished.

Domysee commented 7 years ago

It should be fixed now. If you still have that problem, please reopen the issue.

marnixbent commented 7 years ago

Great solution, thanks.