search

DonBruce64 / MinecraftTransportSimulator

A Minecraft mod that adds planes and automobiles with realistic physics!
Other
111 stars 60 forks source link

[PR] ForwardsDamageMultiplier + tweak for #1592 #1601

Closed boot2big closed 1 year ago

boot2big commented 1 year ago

ForwardsDamageMultiplier will, as the name implies, multiply damage forwarded by whatever it is defined as. 0.5 will deal half damage to the vehicle, 2 will do twice as much and 5 is right out. If not defined, LCs will set this to either 1 or 4, depending on whether the part isn't or is an engine. (The logic being that in (newer versions of) GTA, shooting the engine of a vehicle damages it much more than shooting the doors or body panels.)

boot2big commented 1 year ago

Next PR will be me taking a whack at #1508, these ternary operators are so cool man. How did I forget these exist?

LauraDarkez commented 1 year ago

what am i being asked about?

DonBruce64 commented 1 year ago

what am i being asked about?

If this part is an engine, deal more damage to the vehicle by default

boot2big commented 1 year ago

I'd like to point out that if a FDM is defined, it won't force the 4x multiplier on you. So if you define a 1 from the get-go it'll go back to not multiplying. Will act on the other changes though while waiting for weigh-ins.

LauraDarkez commented 1 year ago

okay, i dont fully understand the purpose of this. is this supposed to be a default or a opt-in via json change? and what is the application of this feature

boot2big commented 1 year ago

It is an opt-out default via json change. The application is for parts that should deal more (or less) damage to the vehicle when forwarding that damage, and if legacyCompat kicks in then by default engines will have a multiplier of 4 while all other parts will remain at no multiplier (or multiplied by 1)

LauraDarkez commented 1 year ago

okay, i dont understand why the engine taking damage would DEFAULTLY deal more damage to the vehicle. this seems like a bad idea

boot2big commented 1 year ago

It was inspiration from GTA IV/V, where shooting the front of a vehicle (or for rear-engine vehicles, the rear) will deal a lot more damage to the vehicle as that is where important bits like fuel lines, the intercooler and the engine tend to be.

LauraDarkez commented 1 year ago

okay, well to be honest i think it should NOT default to be higher, and instead should just be an optional json line you can put in with a higher value. the default should not be higher than 1

boot2big commented 1 year ago

https://github.com/DonBruce64/MinecraftTransportSimulator/wiki/Pack-Making-JSON-Parts I liked the part where he said "it's wiki'ing time" and he wiki'd all over this page!