search

DonBruce64 / MinecraftTransportSimulator

A Minecraft mod that adds planes and automobiles with realistic physics!
Other
113 stars 61 forks source link

[PR] Made isTwoHanded, fireDelay and spreadFactor variable-modifiable as per #1508 #1608

Closed boot2big closed 1 year ago

boot2big commented 1 year ago

Just make sure to update the immortal tome that is the wiki to include a * by the variables that are now VMable.

https://github.com/DonBruce64/MinecraftTransportSimulator/wiki/Pack-Making-JSON-Parts I liked the part where he said "it's wiki'ing time" and he wiki'd all over this page!

No comments on the code.

What exactly am I supposed to comment on? This was a pretty simple PR, the definition.variableModifiers section already has the standard "Adjust current variables to modifiers, if any exist." comment and the rest was pretty much plug-and-play from there... Am simply unsure on what else to leave comments for.

LauraDarkez commented 1 year ago

when it comes to testing this, i already have a json with the vms required set

DonBruce64 commented 1 year ago

Just make sure to update the immortal tome that is the wiki to include a * by the variables that are now VMable.

https://github.com/DonBruce64/MinecraftTransportSimulator/wiki/Pack-Making-JSON-Parts I liked the part where he said "it's wiki'ing time" and he wiki'd all over this page!

No comments on the code.

What exactly am I supposed to comment on? This was a pretty simple PR, the definition.variableModifiers section already has the standard "Adjust current variables to modifiers, if any exist." comment and the rest was pretty much plug-and-play from there... Am simply unsure on what else to leave comments for.

Oh, no no no. I mean I myself don't have any comments and the code is fine, not that you need to put any in there.