DonBruce64 / MinecraftTransportSimulator

A Minecraft mod that adds planes and automobiles with realistic physics!
Other
113 stars 61 forks source link

[Suggestion] Despawn bullets when they cross the worldborder #1718

Open andryqx opened 1 year ago

andryqx commented 1 year ago

Hi! I would like to suggest you to implement new feature: despawn any bullets that reached/crossed world border. That thing would be really useful, because when isLongRange: true bullet reaches the world border, it can fly up to +30000-40000 coords, causing huge fps and tps drops.

DonBruce64 commented 1 year ago

Does this TPS/FPS drop happen ONLY when the bullet crosses the worldBorder, or does it happen for any instance of the bullet firing?

andryqx commented 1 year ago

Does this TPS/FPS drop happen ONLY when the bullet crosses the worldBorder, or does it happen for any instance of the bullet firing?

This TPS/FPS is happenning for any instance of the bullet firing, but if bullet crossed worldborder, it can fly up to 40000 blocks, and this thing can even kill server/local world, with tps/fps dropping.

My suggestion's point is in killing all mts entities which crossed the world border

DonBruce64 commented 1 year ago

Well, the bullet shouldn't be doing physics outside the world border, but I can at least check for them outside said border to prevent this. For now though, don't be playing near the border, there's millions of square feet to play around, you don't need to do so right on the edge!

andryqx commented 1 year ago

``

Well, the bullet shouldn't be doing physics outside the world border, but I can at least check for them outside said border to prevent this. For now though, don't be playing near the border, there's millions of square feet to play around, you don't need to do so right on the edge!

My server has map 3000x3000

DonBruce64 commented 1 year ago

Noted, I'll implement this when I can, but it will likely have to wait for me to finish up the branch where entities are handled by my own code rather than MC's.