DonDebonair / pelican-bootstrap3

Bootstrap 3 theme for Pelican
330 stars 259 forks source link

Custom CSS in Tipue search page #188

Closed cranmer closed 9 years ago

cranmer commented 9 years ago

I added a custom.css to make the search look nicer (see: http://diana-hep.github.io). That works, but the search.html page doesn't include the custom css. I'm not sure yet if that's an issue with that plugin or the theme.

DonDebonair commented 9 years ago

You caught a bug, so thanks for that! The Tipue css was included twice on the search page, overriding the custom.css. Should be fixed now :)

cranmer commented 9 years ago

After this change the page is styled correctly, but the search results all point to "undefined". Previously the search results worked, it just had a css problem. In the mean time, I added a custom URL to the github pages hosting. Now the site is at http://diana-hep.org/ -- I'm not sure if there is an issue with hosting on github pages with a custom URL. The tipue JSON on the server points to urls are of the form http://diana-hep.org/{page} The source is here: https://github.com/diana-hep/diana-hep.github.io-source .

Any ideas?

Does https://github.com/DandyDev/pelican-bootstrap3/blob/master/templates/search.html#L20 need {{SITEURL}} as in this example?

DonDebonair commented 9 years ago

Does https://github.com/DandyDev/pelican-bootstrap3/blob/master/templates/search.html#L20 need {{SITEURL}} as in this example?

Not that I know of. I did change the search behaviour a bit though: https://github.com/DandyDev/pelican-bootstrap3/commit/bf0a77ede4263dc4cc1af9ae774519601891025c People were complaining that the search action pointed to the hard-coded endpoint /search, which would only work if you had the right .htaccess rewrite rule(s). I now changed it so it can be configured using the SEARCH_URL setting. By default it now points to /search.html so that it works in development mode.

If you depended - like me - on /search working, you can fix it by adding this to your settings:

SEARCH_URL = '/search'

Hope that helps!

cranmer commented 9 years ago

I'll try. I'm still Not sure why it broke. On Sun, May 31, 2015 at 2:23 PM Daan Debie notifications@github.com wrote:

Does

https://github.com/DandyDev/pelican-bootstrap3/blob/master/templates/search.html#L20 need {{SITEURL}} as in this example?

Not that I know of. I did change the search behaviour a bit though: bf0a77e https://github.com/DandyDev/pelican-bootstrap3/commit/bf0a77ede4263dc4cc1af9ae774519601891025c People were complaining that the search action pointed to the hard-coded endpoint /search, which would only work if you had the right .htaccess rewrite rule(s). I now changed it so it can be configured using the SEARCH_URL setting. By default it now points to /search.html so that it works in development mode.

If you depended - like me - on /search working, you can fix it by adding this to your settings:

SEARCH_URL = '/search'

Hope that helps!

— Reply to this email directly or view it on GitHub https://github.com/DandyDev/pelican-bootstrap3/issues/188#issuecomment-107247847 .